From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harry van Haaren Subject: [PATCH v4 0/4] eventdev: add attribute based get APIs Date: Thu, 14 Sep 2017 17:08:59 +0100 Message-ID: <1505405343-18234-1-git-send-email-harry.van.haaren@intel.com> References: <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> Cc: jerin.jacob@caviumnetworks.com, Harry van Haaren To: dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CB279374E for ; Thu, 14 Sep 2017 18:08:48 +0200 (CEST) In-Reply-To: <1504885015-44642-1-git-send-email-harry.van.haaren@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset refactors the eventdev API to be more flexible and capable. In particular, the API is capable of returning an error value if an invalid device, port or attribute ID is passed in, which was not possible with the previous APIs. The implementation of this patchset is based on a v1 patch[1], and after some discussion this API was seen as the best solution. In terms of flexibility, the attribute id allows addition of new common eventdev layer attributes without breaking ABI or adding new functions. Note that these attributes are not data-path, and that PMDs should continue to use the xstats API for reporting any unique PMD statistics that are available. Regarding API/ABI compatibility, I have removed the functions from the .map files - please review the .map file changes for ABI issues carefully. The last patch of this series adds a started attribute to the device, allowing the application to query if a device is currently running. -Harry [1] http://dpdk.org/dev/patchwork/patch/27152/ --- v4: - Rework based on review by Jerin - default: cases into switches - Remove old functions from .map file - Remove /* out */ parameters - Rework header file definitions to match logical order - Rework patch split - Cleaner removal of queue_count() function v3: - Fix checkpatch issues... somehow I broke my checkpatch script :/ v2: - New APIs design based on discussion of initial patch. Harry van Haaren (4): eventdev: add port attribute function eventdev: add dev attribute get function eventdev: add queue attribute function eventdev: add device started attribute lib/librte_eventdev/rte_eventdev.c | 97 ++++++++++++------ lib/librte_eventdev/rte_eventdev.h | 115 +++++++++++---------- lib/librte_eventdev/rte_eventdev_version.map | 14 ++- test/test/test_eventdev.c | 132 +++++++++++++++++++------ test/test/test_eventdev_octeontx.c | 143 ++++++++++++++++++++------- 5 files changed, 345 insertions(+), 156 deletions(-) -- 2.7.4