From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 01/22] vhost: introduce driver features
	related APIs
Date: Wed, 05 Apr 2017 02:01:07 +0200
Message-ID: <1505960.GWNM9kVmEz@xps13>
References: <1490705142-893-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1491031380-1499-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1491031380-1499-2-git-send-email-yuanhan.liu@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Harris James R <james.r.harris@intel.com>,
 Liu Changpeng <changpeng.liu@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com
 [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 07564326C
 for <dev@dpdk.org>; Wed,  5 Apr 2017 02:01:09 +0200 (CEST)
Received: by mail-wr0-f172.google.com with SMTP id w43so224846395wrb.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 17:01:09 -0700 (PDT)
In-Reply-To: <1491031380-1499-2-git-send-email-yuanhan.liu@linux.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-01 15:22, Yuanhan Liu:
> +/**
> + * Set the feature bits the vhost-user driver supports.
> + *
> + * @param path
> + *  The vhost-user socket file path
> + * @return
> + *  0 on success, -1 on failure
> + */
> +int rte_vhost_driver_set_features(const char *path, uint64_t features);

The parameter @features is not documented.

I suggest
+ * @param features
+ *  Supported features