From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] checkpatch: re-enable warnings about split
 long strings
Date: Mon, 02 Oct 2017 11:01:17 +0100
Message-ID: <1506938477.7585.1.camel@debian.org>
References: <20170929153749.9806-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68])
 by dpdk.org (Postfix) with ESMTP id F3E311B1BF
 for <dev@dpdk.org>; Mon,  2 Oct 2017 12:01:19 +0200 (CEST)
Received: by mail-wm0-f68.google.com with SMTP id f4so1353036wme.0
 for <dev@dpdk.org>; Mon, 02 Oct 2017 03:01:19 -0700 (PDT)
In-Reply-To: <20170929153749.9806-1-stephen@networkplumber.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2017-09-29 at 08:37 -0700, Stephen Hemminger wrote:
> The Linux kernel style policy about strings is that strings should
> be always put on one line. This makes sense since a typical use
> case is for a user to type the error message into a search engine
> or grep, and it won't be found if split across lines.
> This patch just re-enables that check.
>=20
> Yes, lots of DPDK code now splits strings, that doesn't
> make it right.
>=20
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> =C2=A0devtools/checkpatches.sh | 1 -
> =C2=A01 file changed, 1 deletion(-)
>=20
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index a56c41a301c0..3e6081dd673e 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -44,7 +44,6 @@ options=3D"$options --show-types"
> =C2=A0options=3D"$options --ignore=3DLINUX_VERSION_CODE,FILE_PATH_CHANGES=
,\
> =C2=A0VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
> =C2=A0PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
> -SPLIT_STRING,LONG_LINE_STRING,\
> =C2=A0LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> =C2=A0NEW_TYPEDEFS,COMPARISON_TO_NULL"
> =C2=A0

Acked-by: Luca Boccassi <bluca@debian.org>

+1 - being able to reliably Google/grep across such a large code base
is extremely useful

--=20
Kind regards,
Luca Boccassi