From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Piasecki Subject: [PATCH v2] examples/vhost_scsi: fix buffer not terminated Date: Thu, 12 Oct 2017 08:44:55 +0200 Message-ID: <1507790695-10449-1-git-send-email-jacekx.piasecki@intel.com> References: <20170922130734.7256-1-michalx.k.jastrzebski@intel.com> Cc: maxime.coquelin@redhat.com, changpeng.liu@intel.com, deepak.k.jain@intel.com, michalx.k.jastrzebski@intel.com, Jacek Piasecki , stable@dpdk.org To: dev@dpdk.org Return-path: In-Reply-To: <20170922130734.7256-1-michalx.k.jastrzebski@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use snprintf instead strncpy to get safe null string termination. There was possible to get not terminated string after strncpy operation. Coverity issue: 158631 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Cc: changpeng.liu@intel.com Cc: stable@dpdk.org Signed-off-by: Jacek Piasecki --- v2: * use snprintf instead strncpy examples/vhost_scsi/scsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c index 54d3104..c0f3187 100644 --- a/examples/vhost_scsi/scsi.c +++ b/examples/vhost_scsi/scsi.c @@ -307,7 +307,8 @@ strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8); /* PRODUCT IDENTIFICATION */ - strncpy((char *)inqdata->product_id, bdev->product_name, 16); + snprintf((char *)inqdata->product_id, + ARRAY_SIZE(inqdata->product_id), "%s", bdev->product_name); /* PRODUCT REVISION LEVEL */ strncpy((char *)inqdata->product_rev, "0001", 4); -- 1.9.1