From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <luca.boccassi@gmail.com>
Subject: Re: [PATCH v7 6/6] mk: install symlinks before build step
Date: Thu, 12 Oct 2017 13:19:38 +0100
Message-ID: <1507810778.22352.5.camel@gmail.com>
References: <20170905205159.8606-7-luca.boccassi@gmail.com>
 <8436144.K3qalYn0E0@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id DAA9E1B266
 for <dev@dpdk.org>; Thu, 12 Oct 2017 14:19:40 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id k4so12828768wmc.1
 for <dev@dpdk.org>; Thu, 12 Oct 2017 05:19:40 -0700 (PDT)
In-Reply-To: <8436144.K3qalYn0E0@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 2017-10-12 at 04:58 +0200, Thomas Monjalon wrote:
> 05/09/2017 22:51, luca.boccassi@gmail.com:
> > =C2=A0.PHONY: install
> > +ifeq ($(SYMLINK-FILES-y),)
> > =C2=A0install: build _postinstall
> > +else
> > +install: _preinstall build _postinstall
> > +endif
>=20
> I think you cannot be sure that "_preinstall" will be finished
> before the "build" target starts in parallel make.
> Am I missing something?

Yes, you are right, good catch. I'll add a dependency:

build: _preinstall

Which should take care of it, retest and send a new version.

--=20
Kind regards,
Luca Boccassi