From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] i40evf: fix of supporting jumbo frame Date: Thu, 04 Jun 2015 12:04:20 +0200 Message-ID: <1507815.0z9D0b3jov@xps13> References: <1430962859-26782-1-git-send-email-helin.zhang@intel.com> <1433400872-6156-1-git-send-email-helin.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Helin Zhang Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 1CC3FB3D6 for ; Thu, 4 Jun 2015 12:05:13 +0200 (CEST) Received: by wgv5 with SMTP id 5so29587442wgv.1 for ; Thu, 04 Jun 2015 03:05:13 -0700 (PDT) In-Reply-To: <1433400872-6156-1-git-send-email-helin.zhang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-04 14:54, Helin Zhang: > It wouldn't check the configured maximum packet length, and then > the scattered receiving function wouldn't be selected at all even > if it wants to receive a jumbo frame. The fix is to select the > correct RX function according to the configurations. > > Signed-off-by: Helin Zhang > --- > drivers/net/i40e/i40e_ethdev.h | 2 + > drivers/net/i40e/i40e_ethdev_vf.c | 85 ++++++++++++++++++++++++++------------- > drivers/net/i40e/i40e_rxtx.c | 1 - > 3 files changed, 59 insertions(+), 29 deletions(-) > > v2 changes: > * Removed maximum packet length check and jumbo frame check in > i40evf_dev_start(), as the same checks are already in each queue > initialization. > > v3 changes: > * Added code style fixes. Applied, thanks