From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 1/8] build: add maths library to libs in
 pkg-config file
Date: Tue, 17 Oct 2017 19:17:09 +0100
Message-ID: <1508264229.32437.3.camel@debian.org>
References: <20171017161220.59941-1-bruce.richardson@intel.com>
 <20171017161220.59941-2-bruce.richardson@intel.com>
 <1508263898.32437.1.camel@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com
 [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 487CD1B722
 for <dev@dpdk.org>; Tue, 17 Oct 2017 20:17:11 +0200 (CEST)
Received: by mail-wr0-f193.google.com with SMTP id z99so160924wrc.12
 for <dev@dpdk.org>; Tue, 17 Oct 2017 11:17:11 -0700 (PDT)
In-Reply-To: <1508263898.32437.1.camel@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2017-10-17 at 19:11 +0100, Luca Boccassi wrote:
> On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote:
> > Since a number of libraries depend on the maths lib, as well as
> > adding it
> > to the project args, we also need to add it to the pkgconfig file
> > args.
> >=20
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > =C2=A0config/meson.build | 1 +
> > =C2=A01 file changed, 1 insertion(+)
> >=20
> > diff --git a/config/meson.build b/config/meson.build
> > index db68a08d4..542fea4de 100644
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > @@ -35,6 +35,7 @@ dpdk_conf.set('RTE_MACHINE', machine)
> > =C2=A0add_project_arguments('-march=3D@0@'.format(machine), language: '=
c')
> > =C2=A0# some libs depend on maths lib
> > =C2=A0add_project_link_arguments('-lm', language: 'c')
> > +dpdk_extra_ldflags +=3D '-lm'
> > =C2=A0
> > =C2=A0# add -include rte_config to cflags
> > =C2=A0add_project_arguments('-include', 'rte_config.h', language: 'c')
>=20
> This is for static builds, right? If so it should go into the
> Libs.private section of the .pc file, so that it's only used when
> calling pkg-config --static --libs

Bit of a brain fart - what I meant is, in order to have static builds
work out of the box with pkg-config --static, -lm (and any other
dependency used internally) could also be added to Libs.private in the
.pc

--=20
Kind regards,
Luca Boccassi