From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: [PATCH] net/sfc: fix Tx reap behaviour on port stop on EF10 datapath Date: Wed, 18 Oct 2017 10:39:57 +0100 Message-ID: <1508319597-21039-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Ivan Malov To: Return-path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 842C71B2C1 for ; Wed, 18 Oct 2017 11:40:20 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ivan Malov Tx reap mechanism on EF10 native datapath was altered by one of the recent patches to introduce performance optimisations using the common technique of freeing mbuf segments in bulks. >>From this perspective, the way of associating SW descriptors with individual mbuf segments rather than with whole packets was adopted as a key requirement for the entire optimisation. However, only the fast path reap function was amended to fit the new scheme whilst the corresponding function on the port stop path was left intact by mistake. This implies incorrect usage of rte_pktmbuf_free() with regard to separate segments rather than calling rte_pktmbuf_free_seg() and must be fixed. Fixes: d321954343c8 ("net/sfc: free mbufs in bulks on EF10 native Tx reap") Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_ef10_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c index 9047b3e..167c91d 100644 --- a/drivers/net/sfc/sfc_ef10_tx.c +++ b/drivers/net/sfc/sfc_ef10_tx.c @@ -602,7 +602,7 @@ sfc_ef10_tx_qreap(struct sfc_dp_txq *dp_txq) txd = &txq->sw_ring[completed & txq->ptr_mask]; if (txd->mbuf != NULL) { - rte_pktmbuf_free(txd->mbuf); + rte_pktmbuf_free_seg(txd->mbuf); txd->mbuf = NULL; } } -- 2.7.4