From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ori Kam Subject: [PATCH] net/mlx5: fix add counter when dev not started Date: Mon, 30 Oct 2017 09:32:24 +0200 Message-ID: <1509348744-20476-1-git-send-email-orika@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org, orika@mellanox.com To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50048.outbound.protection.outlook.com [40.107.5.48]) by dpdk.org (Postfix) with ESMTP id E7E141B31E for ; Mon, 30 Oct 2017 08:32:47 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When adding count action to a drop flow rule while the device was not stated, the counter was not saved in the flow. Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") Cc: orika@mellanox.com Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index f392f1f..3999b84 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1690,13 +1690,13 @@ struct ibv_spec_header { ++parser->drop_q.ibv_attr->num_of_specs; parser->drop_q.offset += size; flow->drxq.ibv_attr = parser->drop_q.ibv_attr; + if (parser->count) + flow->cs = parser->cs; if (!priv->dev->data->dev_started) return 0; parser->drop_q.ibv_attr = NULL; flow->drxq.ibv_flow = ibv_create_flow(priv->flow_drop_queue->qp, flow->drxq.ibv_attr); - if (parser->count) - flow->cs = parser->cs; if (!flow->drxq.ibv_flow) { rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "flow rule creation failure"); -- 1.7.1