From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernard Iremonger Subject: [PATCH] examples/flow_classify: fix fseek error handling Date: Wed, 1 Nov 2017 12:10:29 +0000 Message-ID: <1509538229-1354-1-git-send-email-bernard.iremonger@intel.com> Cc: Bernard Iremonger To: dev@dpdk.org, jasvinder.singh@intel.com Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 523AF1B21B for ; Wed, 1 Nov 2017 13:10:35 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Check return value of fseek and exit if non zero. Coverity issue: 143435 Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") Signed-off-by: Bernard Iremonger --- examples/flow_classify/flow_classify.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c index e4cabdb..766f1dd 100644 --- a/examples/flow_classify/flow_classify.c +++ b/examples/flow_classify/flow_classify.c @@ -657,13 +657,17 @@ static __attribute__((noreturn)) void unsigned int i = 0; unsigned int total_num = 0; struct rte_eth_ntuple_filter ntuple_filter; + int ret; fh = fopen(rule_path, "rb"); if (fh == NULL) - rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, + rte_exit(EXIT_FAILURE, "%s: fopen %s failed\n", __func__, rule_path); - fseek(fh, 0, SEEK_SET); + ret = fseek(fh, 0, SEEK_SET); + if (ret) + rte_exit(EXIT_FAILURE, "%s: fseek %d failed\n", __func__, + ret); i = 0; while (fgets(buff, LINE_MAX, fh) != NULL) { -- 1.9.1