From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: [PATCH] net/mrvl: reset errno before library call Date: Thu, 2 Nov 2017 09:37:25 +0100 Message-ID: <1509611845-19698-1-git-send-email-tdu@semihalf.com> Cc: Tomasz Duszynski To: dev@dpdk.org Return-path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 2EE281B31B for ; Thu, 2 Nov 2017 09:37:57 +0100 (CET) Received: by mail-lf0-f68.google.com with SMTP id e143so5444560lfg.12 for ; Thu, 02 Nov 2017 01:37:57 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case errno contains some non-zero value and call to strtoul() is successful -2 error will be returned. Setting errno to zero before calling strtoul() makes sure errors will be handled correctly. Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_qos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mrvl/mrvl_qos.c b/drivers/net/mrvl/mrvl_qos.c index 55f6406..2076228 100644 --- a/drivers/net/mrvl/mrvl_qos.c +++ b/drivers/net/mrvl/mrvl_qos.c @@ -122,6 +122,7 @@ get_val_securely(const char *string, uint32_t *val) if (len == 0) return -1; + errno = 0; *val = strtoul(string, &endptr, 0); if (errno != 0 || RTE_PTR_DIFF(endptr, string) != len) return -2; -- 2.7.4