From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] net/vmxnet3: fix memory leak when releasing
 queues
Date: Thu, 02 Nov 2017 10:03:19 +0000
Message-ID: <1509616999.17108.3.camel@debian.org>
References: <20171101203820.8021-1-3chas3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: skhare@vmware.com
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id E167C1B3B4
 for <dev@dpdk.org>; Thu,  2 Nov 2017 11:03:21 +0100 (CET)
Received: by mail-wr0-f195.google.com with SMTP id l1so4451530wrc.3
 for <dev@dpdk.org>; Thu, 02 Nov 2017 03:03:21 -0700 (PDT)
In-Reply-To: <20171101203820.8021-1-3chas3@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>=20
> At the end of the queue release, we can free the containers for the
> queue objects.
>=20
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
> implementation")
>=20
> Signed-off-by: <chas3@att.com>
> ---
> =C2=A0drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++
> =C2=A01 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index 01c85f1..18dce72 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -203,6 +203,8 @@ vmxnet3_dev_tx_queue_release(void *txq)
> =C2=A0		vmxnet3_cmd_ring_release(&tq->cmd_ring);
> =C2=A0		/* Release the memzone */
> =C2=A0		rte_memzone_free(tq->mz);
> +		/* Release the queue */
> +		rte_free(tq);
> =C2=A0	}
> =C2=A0}
> =C2=A0
> @@ -223,6 +225,9 @@ vmxnet3_dev_rx_queue_release(void *rxq)
> =C2=A0
> =C2=A0		/* Release the memzone */
> =C2=A0		rte_memzone_free(rq->mz);
> +
> +		/* Release the queue */
> +		rte_free(rq);
> =C2=A0	}
> =C2=A0}
> =C2=A0

Reviewed-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi