From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jia He Subject: [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Date: Wed, 8 Nov 2017 06:17:10 +0000 Message-ID: <1510121832-16439-1-git-send-email-hejianet@gmail.com> Cc: konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia He , jia.he@hxt-semitech.com To: jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com Return-path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 021BE1B34F for ; Wed, 8 Nov 2017 07:18:42 +0100 (CET) Received: by mail-pl0-f66.google.com with SMTP id t7so665578plm.0 for ; Tue, 07 Nov 2017 22:18:42 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" for the code as follows: if (condition) rte_smp_rmb(); else rte_smp_wmb(); Without this patch, compiler will report this error: error: 'else' without a previous 'if' Signed-off-by: Jia He Signed-off-by: jia.he@hxt-semitech.com --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h index 0b70d62..38c3393 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h @@ -43,8 +43,8 @@ extern "C" { #include "generic/rte_atomic.h" -#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); } -#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); } +#define dsb(opt) asm volatile("dsb " #opt : : : "memory"); +#define dmb(opt) asm volatile("dmb " #opt : : : "memory"); #define rte_mb() dsb(sy) -- 2.7.4