From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v13 4/8] ethdev: rename link speed constants
Date: Wed, 06 Apr 2016 10:52:37 +0200
Message-ID: <1510689.gPteTu5Ds8@xps13>
References: <1458934950-23333-1-git-send-email-thomas.monjalon@6wind.com>
 <1458955640-22951-5-git-send-email-marcdevel@gmail.com>
 <1AFA2937E172CD4DB2FD9318443C060EE95711@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Marc Sune <marcdevel@gmail.com>, "Xu, Qian Q" <qian.q.xu@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, dev@dpdk.org, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Glynn,
 Michael J" <michael.j.glynn@intel.com>, "Gray, Mark D" <mark.d.gray@intel.com>
To: "Weglicki, MichalX" <michalx.weglicki@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 944F82904
 for <dev@dpdk.org>; Wed,  6 Apr 2016 10:54:15 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id v188so15039967wme.1
 for <dev@dpdk.org>; Wed, 06 Apr 2016 01:54:15 -0700 (PDT)
In-Reply-To: <1AFA2937E172CD4DB2FD9318443C060EE95711@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-04-06 08:34, Weglicki, MichalX:
> Hello, 
> 
> I have a question about this patch. 
> 
> As far as I see changing ETH_LINK_SPEED_ to ETH_SPEED_NUM_ is rather cosmetic change, am I right? 

No.
ETH_LINK_SPEED was used for configuration and reported speed.
Now the configuration is done with a bitmap filled with new ETH_LINK_SPEED
and the old numerical values are kept for other usages as ETH_SPEED_NUM.

> Disadvantage of that is that it breaks compatibility with OVS (compilation) and thus it also breaks backward compatibility between OVS & DPDK. Is it really necessary? 

Yes that's why this change was discussed 9 months ago and announced in the
previous release notes.

> It would be great to keep ABI & API stable if possible.

We try to keep it stable when possible and continue to bring some improvements.