From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4] test/hash: improve hash unit tests
Date: Fri, 10 Jul 2015 12:35:05 +0200
Message-ID: <1511524.5JONc7566D@xps13>
References: <1436444378-29106-2-git-send-email-pablo.de.lara.guarch@intel.com>
 <1436460870-30022-2-git-send-email-pablo.de.lara.guarch@intel.com>
 <20150710091159.GA10556@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 81B5B9E7
 for <dev@dpdk.org>; Fri, 10 Jul 2015 12:36:13 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so62422071wgx.3
 for <dev@dpdk.org>; Fri, 10 Jul 2015 03:36:13 -0700 (PDT)
In-Reply-To: <20150710091159.GA10556@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-10 10:11, Bruce Richardson:
> On Thu, Jul 09, 2015 at 05:54:30PM +0100, Pablo de Lara wrote:
> > Add new unit test for calculating the average table utilization,
> > using random keys, based on number of entries that can be added
> > until we encounter one that cannot be added (bucket if full).
> > 
> > Also, replace current hash_perf unit test to see performance more clear.
> s/clear/clearly/
> 
> > The current hash_perf unit test takes too long and add keys that
> > may or may not fit in the table and look up/delete that may not be
> > in the table. This new unit test gets a set of keys that we know
> > that fits in the table, and then measure the time to add/look up/delete
> > them.
> > 
> > Mind that performance numbers include time to take a random key
> s/Mind/Note/
> 
> > from a pre-made array of keys, plus a quick check of return value.
> > Also, as stated above, expect higher numbers, as all operations
> > in the new unit tests will be successful, which means that
> > it will take more time, than mixing both successful and unsuccesful
> > operations.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Looks good, Pablo. 
> Thomas, perhaps you could make the above minor changes to
> the commit log when applying the patch.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied with above comments, thanks