From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] cfgfile: fix uninitialized variable on load
	error
Date: Mon, 13 Feb 2017 22:07:35 +0100
Message-ID: <1512191.29lNYdtJif@xps13>
References: <1486435866-30562-1-git-send-email-bombermag@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Dmitriy Yakovlev <bombermag@gmail.com>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com
 [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 9481558CF
 for <dev@dpdk.org>; Mon, 13 Feb 2017 22:07:37 +0100 (CET)
Received: by mail-wr0-f174.google.com with SMTP id k90so158751837wrc.3
 for <dev@dpdk.org>; Mon, 13 Feb 2017 13:07:37 -0800 (PST)
In-Reply-To: <1486435866-30562-1-git-send-email-bombermag@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Ping Cristian

2017-02-07 05:51, Dmitriy Yakovlev:
> Uninitialized scalar variable. Using uninitialized value cfg->sections[curr_section]->num_entries when calling rte_cfgfile_close.
> And memory in variables cfg->sections[curr_section], sect->entries[curr_entry] maybe not equal NULL. We must decrement counters curr_section, curr_entry when failed to realloc.
> 
> Fixes: eaafbad419bf ("cfgfile: library to interpret config files")
> 
> Signed-off-by: Dmitriy Yakovlev <bombermag@gmail.com>