From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Azrad Subject: [PATCH v3 1/3] net/failsafe: fix Rx safe check compiler hint Date: Tue, 19 Dec 2017 17:14:27 +0000 Message-ID: <1513703669-29363-2-git-send-email-matan@mellanox.com> References: <1513703669-29363-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org, stable@dpdk.org To: Gaetan Rivet Return-path: In-Reply-To: <1513703669-29363-1-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" failsafe_rx_burst function is used when there are no sub-devices or at least one of them has been removed, on the other hand, when all the sub-devices are present, failsafe_rx_burst_fast function is used. So it's really expected that some of the sub-devices will be unsafe for Rx burst in failsafe_rx_burst execution. Remove unlikely compiler hint from fs_rx_unsafe calling. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/failsafe/failsafe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_rxtx.c b/drivers/net/failsafe/failsafe_rxtx.c index 70157c8..178294c 100644 --- a/drivers/net/failsafe/failsafe_rxtx.c +++ b/drivers/net/failsafe/failsafe_rxtx.c @@ -111,7 +111,7 @@ if (i == priv->subs_tail) i = priv->subs_head; sdev = &priv->subs[i]; - if (unlikely(fs_rx_unsafe(sdev))) + if (fs_rx_unsafe(sdev)) continue; sub_rxq = ETH(sdev)->data->rx_queues[rxq->qid]; FS_ATOMIC_P(rxq->refcnt[sdev->sid]); -- 1.8.3.1