From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qi Zhang Subject: [PATCH 2/2] net/e1000: fix mailbox interrupt handler Date: Wed, 27 Dec 2017 15:22:30 -0500 Message-ID: <1514406150-17517-2-git-send-email-qi.z.zhang@intel.com> References: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> Cc: dev@dpdk.org, wei.dai@intel.com, liang-min.wang@intel.com, Qi Zhang , stable@dpdk.org To: wenzhuo.lu@intel.com Return-path: In-Reply-To: <1514406150-17517-1-git-send-email-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Mailbox interrupt handler only take care of the PF reset notification, for other message mbx->ops.read should not be called since it get chance to break the foreground VF to PF communication. Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down") Cc: stable@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/e1000/igb_ethdev.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index fdc139f..0d8bc49 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -2970,13 +2970,17 @@ void igbvf_mbx_process(struct rte_eth_dev *dev) struct e1000_mbx_info *mbx = &hw->mbx; u32 in_msg = 0; - if (mbx->ops.read(hw, &in_msg, 1, 0)) - return; + /* peek the message first */ + in_msg = E1000_READ_REG(hw, E1000_VMBMEM(0)); /* PF reset VF event */ - if (in_msg == E1000_PF_CONTROL_MSG) + if (in_msg == E1000_PF_CONTROL_MSG) { + /* dummy mbx read to ack pf */ + if (mbx->ops.read(hw, &in_msg, 1, 0)) + return; _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, NULL, NULL); + } } static int -- 2.7.4