From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ring: fix build with icc Date: Wed, 05 Apr 2017 18:15:29 +0200 Message-ID: <1515186.mOWQOvkDvU@xps13> References: <20170405150312.20960-1-ferruh.yigit@intel.com> <20170405161354.GB15156@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Bruce Richardson , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id D8C24326C for ; Wed, 5 Apr 2017 18:15:33 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id w11so20197449wrc.3 for ; Wed, 05 Apr 2017 09:15:33 -0700 (PDT) In-Reply-To: <20170405161354.GB15156@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-04-05 17:13, Bruce Richardson: > On Wed, Apr 05, 2017 at 04:03:12PM +0100, Ferruh Yigit wrote: > > build error: > > In file included from .../lib/librte_ring/rte_ring.c(90): > > .../lib/librte_ring/rte_ring.h(162): > > error #1366: a reduction in alignment without the "packed" attribute > > is ignored > > } __rte_cache_aligned; > > ^ > > > > Alignment attribute moved to first element of the struct > > > > Fixes: a6619414e0a9 ("ring: make struct and macros type agnostic") > > > > Signed-off-by: Ferruh Yigit > > --- > Patch looks ok to me > > Signed-off-by: Bruce Richardson Applied, thanks