From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev,
	v2] net/e1000: always enable receive and transmit
Date: Thu, 11 Jan 2018 16:22:54 +0800
Message-ID: <1515658974-63940-1-git-send-email-wenzhuo.lu@intel.com>
References: <20171020032339.24079-1-3chas3@gmail.com>
To: chas3@att.com,
	dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id B097D1B1E5
 for <dev@dpdk.org>; Thu, 11 Jan 2018 09:20:56 +0100 (CET)
In-Reply-To: <20171020032339.24079-1-3chas3@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

> Date: Thu, 19 Oct 2017 23:23:39 -0400
>
> From: Chas Williams <chas3@att.com>
>
> The transmit and receive controller state machines are only enabled after
> receiving an interrupt and the link status is now valid.  If an adapter
> is being used in conjunction with NC-SI, network controller sideband
> interface, the adapter may never get a link state change interrupt since
> the adapter's PHY is always link up and never changes state.
>
> To fix this, always enable and disable the transmit and receive with
> .dev_start and .dev_stop.  This is a better match for what is typically
> done with the other PMD's.  Since we may never get an interrupt to check
> the link state, we also poll once at the end of .dev_start to get the
> current link status.
>
> Signed-off-by: Chas Williams <chas3@att.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>