From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Yang Subject: [PATCH] test/memzone: Fix test_memzone_basic & test_memzone_free issues. Date: Thu, 11 Jan 2018 17:41:46 +0800 Message-ID: <1515663706-762-1-git-send-email-phil.yang@arm.com> Cc: nd@arm.com, jianbo.liu@arm.com, herbert.guan@arm.com To: dev@dpdk.org Return-path: Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 627CF58D1 for ; Thu, 11 Jan 2018 10:41:55 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 1. test_memzone_basic: No need to free a NULL memzone. It will cause test termination. 2. test_memzone_free: Out of mz[RTE_MAX_MEMZONE] memory bound while reserving memzone for mz. It will flush variable i. Fix by extend to mz[RTE_MAX_MEMZONE + 1]. Signed-off-by: Phil Yang --- test/test/test_memzone.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c index 6e80977..24e29a7 100644 --- a/test/test/test_memzone.c +++ b/test/test/test_memzone.c @@ -251,10 +251,6 @@ test_memzone_reserve_flags(void) printf("MEMZONE FLAG 2MB\n"); return -1; } - if (rte_memzone_free(mz)) { - printf("Fail memzone free\n"); - return -1; - } } if (hugepage_2MB_avail && hugepage_1GB_avail) { @@ -746,7 +742,7 @@ test_memzone_bounded(void) static int test_memzone_free(void) { - const struct rte_memzone *mz[RTE_MAX_MEMZONE]; + const struct rte_memzone *mz[RTE_MAX_MEMZONE + 1]; int i; char name[20]; -- 2.7.4