From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vipin Varghese Subject: [PATCH v2] eal/service: add routine to release memory Date: Wed, 24 Jan 2018 14:13:21 +0530 Message-ID: <1516783401-4811-1-git-send-email-vipin.varghese@intel.com> References: <1516777408-4187-1-git-send-email-vipin.varghese@intel.com> Cc: deepak.k.jain@intel.com, john.mcnamara@intel.com, stable@dpdk.org, amol.patel@intel.com, Vipin Varghese To: harry.van.haaren@intel.com, dev@dpdk.org Return-path: In-Reply-To: <1516777408-4187-1-git-send-email-vipin.varghese@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The routine rte_service_finalize checks if service is initialized, if yes; releases internal memory for services and lcore states. This routine is to be invoked at end of application termination. Signed-off-by: Vipin Varghese --- V2 Changes: - redo the logic for rte_service_finalize - added in alphabetical order - cleaned up commit message --- lib/librte_eal/common/rte_service.c | 16 +++++++++------- lib/librte_eal/rte_eal_version.map | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 5133c98..dba74a3 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -110,14 +110,16 @@ int32_t rte_service_init(void) void rte_service_finalize(void) { - if (rte_service_library_initialized) { - if (rte_services) - rte_free(rte_services); - if (lcore_states) - rte_free(lcore_states); + if (!rte_service_library_initialized) + return; - rte_service_library_initialized = 0; - } + if (rte_services) + rte_free(rte_services); + + if (lcore_states) + rte_free(lcore_states); + + rte_service_library_initialized = 0; } diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index 24d1ca7..1a8b1b5 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -223,6 +223,7 @@ EXPERIMENTAL { rte_service_component_unregister; rte_service_component_runstate_set; rte_service_dump; + rte_service_finalize; rte_service_get_by_id; rte_service_get_by_name; rte_service_get_count; @@ -245,6 +246,5 @@ EXPERIMENTAL { rte_service_set_runstate_mapped_check; rte_service_set_stats_enable; rte_service_start_with_defaults; - rte_service_finalize; } DPDK_18.02; -- 1.9.1