From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/5]: Cleanups in the ixgbe PMD Date: Thu, 07 May 2015 19:25:02 +0200 Message-ID: <1517243.9KvEt0E09c@xps13> References: <1430296697-32650-1-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB97725821422676@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Vlad Zolotarov Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB97725821422676-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > This series includes: > > - Fix the "issue" introduced in 01fa1d6215fa7cd6b5303ac9296381b75b9226de: > > files in librte_pmd_ixgbe/ixgbe/ are shared with FreeBSD and AFAIU should not > > be changed unless the change is pushed into the FreeBSD tree first. > > - Remove unused rsc_en field in ixgbe_rx_queue struct. > > Thanks to Shiweixian for pointing this out. > > - Kill the non-vector scattered Rx callback and use an appropriate LRO callback > > instead. This is possible because work against HW in both LRO and scattered RX > > cases is the same. Note that this patch touches the ixgbevf PMD as well. > > - Use LRO bulk callback when scattered (non-LRO) Rx is requested and parameters > > allow bulk allocation. > > > > Note that this series is meant to cleanup the PF PMD and is a follow up series for my > > previous patches. Although VF PMD is slightly modified here too this series doesn't mean > > to fix/add new functionality to it. VF PMD should be patched in the similar way I've > > patched PF PMD in my previous series in order to fix the same issues that were fixed in > > the PF PMD and in order to enable LRO and scattered Rx with bulk allocations. > > > > New in v2: > > - Rename RSC-specific structures to "Scattered Rx" derivatives. > > - Always allocate Scattered Rx ring. > > > > Vlad Zolotarov (5): > > ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter > > ixgbe: ixgbe_rx_queue: remove unused rsc_en field > > ixgbe: Rename yy_rsc_xx -> yy_sc/scattered_rx_xx > > ixgbe: Kill ixgbe_recv_scattered_pkts() > > ixgbe: Add support for scattered Rx with bulk allocation. > > Acked-by: Konstantin Ananyev > Thanks a lot for doing it. Applied, thanks