From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingjing Wu Subject: [PATCH 1/2] net/avf: fix unchecked return value issue Date: Tue, 30 Jan 2018 13:54:31 +0800 Message-ID: <1517291671-56210-1-git-send-email-jingjing.wu@intel.com> Cc: jingjing.wu@intel.com, dev@dpdk.org To: wenzhuo.lu@intel.com Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 365441B342 for ; Tue, 30 Jan 2018 07:03:26 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes the coverity CHECKED_RETURN issue. Coverity issue: 257045 Fixes: 48de41ca11f0 ("net/avf: enable link status update") Reported-by: John McNamara Signed-off-by: Jingjing Wu --- drivers/net/avf/avf_ethdev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index cf7bbb2..511715f 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -609,9 +609,10 @@ avf_dev_link_update(struct rte_eth_dev *dev, new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); - rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, - *(uint64_t *)&dev->data->dev_link, - *(uint64_t *)&new_link); + if(rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, + *(uint64_t *)&dev->data->dev_link, + *(uint64_t *)&new_link) == 0) + return -1; return 0; } -- 2.4.11