From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Azrad Subject: [PATCH 2/2] app/testpmd: fix invalid port detach Date: Tue, 30 Jan 2018 14:13:40 +0000 Message-ID: <1517321620-14198-2-git-send-email-matan@mellanox.com> References: <1517321620-14198-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org To: Wenzhuo Lu Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0057.outbound.protection.outlook.com [104.47.1.57]) by dpdk.org (Postfix) with ESMTP id 836631B41F for ; Tue, 30 Jan 2018 15:14:15 +0100 (CET) In-Reply-To: <1517321620-14198-1-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using registration to all ports includes also the ports which should not be used by the application. It is nice to print each port event by testpmd but in case of RMV event, testpmd tries to detach the port and this case is problematic when the port should not be used by the application. Check the port validation before detach API calling. Fixes: 4fb82244b394 ("app/testpmd: extend event printing") Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8cca..71b03d5 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2026,6 +2026,9 @@ struct pmd_test_command { fflush(stdout); } + if (port_id_is_invalid(port_id, DISABLED_WARN)) + return 0; + switch (type) { case RTE_ETH_EVENT_INTR_RMV: if (rte_eal_alarm_set(100000, -- 1.8.3.1