From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amr Mokhtar Subject: [PATCH] app/testbbdev: fix buffer null termination due to strncpy Date: Wed, 31 Jan 2018 12:40:40 +0000 Message-ID: <1517402440-129255-1-git-send-email-amr.mokhtar@intel.com> Cc: Amr Mokhtar To: dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 641C31B792 for ; Wed, 31 Jan 2018 13:40:45 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" use snprintf instead of strncpy to ensure null termination when copying test_vector_filename from cmd arguments. Coverity issue: 257001 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Amr Mokhtar --- app/test-bbdev/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/main.c b/app/test-bbdev/main.c index 3f542a8..41b54bb 100644 --- a/app/test-bbdev/main.c +++ b/app/test-bbdev/main.c @@ -226,8 +226,9 @@ parse_args(int argc, char **argv, struct test_params *tp) TEST_ASSERT(strlen(optarg) > 0, "Config file name is null"); - strncpy(tp->test_vector_filename, optarg, - sizeof(tp->test_vector_filename)); + snprintf(tp->test_vector_filename, + sizeof(tp->test_vector_filename), + "%s", optarg); break; case 'l': TEST_ASSERT(strlen(optarg) > 0, -- 2.7.4