From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] meter: fix excess token bucket update in srtcm implementation Date: Wed, 21 Sep 2016 23:19:04 +0200 Message-ID: <1517417.ujR0TQTeQH@xps13> References: <1473228910-10429-1-git-send-email-nikhil.jagtap@gmail.com> <1474437462-6955-1-git-send-email-nikhil.jagtap@gmail.com> <3EB4FA525960D640B5BDFFD6A3D8912647A85CB4@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Dumitrescu, Cristian" , "Ramia, Kannan Babu" To: Nikhil Jagtap Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 885545589 for ; Wed, 21 Sep 2016 23:20:16 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id w84so217122962wmg.1 for ; Wed, 21 Sep 2016 14:20:16 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A85CB4@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > As per srTCM RFC 2697, we should be updating the E bucket only after the > > C bucket overflows. This patch fixes the current DPDK implementation, > > where we are updating both the buckets simultaneously at the same rate > > (CIR) which results in token accumulation rate of (2*CIR). > > > > Signed-off-by: Nikhil Jagtap > > Acked-by: Cristian Dumitrescu Applied, thanks