From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] i40evf: fix crash when setup tx queues on vf port Date: Thu, 30 Jul 2015 00:33:03 +0200 Message-ID: <1517577.ZUUS3DXQqZ@xps13> References: <1438074060-13809-1-git-send-email-jingjing.wu@intel.com> <1438131297-22750-1-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Jingjing Wu Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 4A2C0C4A8 for ; Thu, 30 Jul 2015 00:34:19 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so220479539wib.0 for ; Wed, 29 Jul 2015 15:34:19 -0700 (PDT) In-Reply-To: <1438131297-22750-1-git-send-email-jingjing.wu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > This patch fixes the issue: > Testpmd crashed with Segmentation fault when setup tx queues on vf > Steps for reproduce: > - create one vf device from i40e driver > - bind vf device to igb_uio and start testpmd > > With debugging tools, we saw the struct i40e_vf is cleared after > memcpy(&dev->data->dev_conf, dev_conf, sizeof(dev->data->dev_conf)) in > rte_eth_dev_configure, which should not happen, and the pointer to > i40e_vf isn't in the range of i40e_adapter. > > The root cause is the dev_private_size in i40e virtual function driver struct > rte_i40evf_pmd was set incorrectly. > > Signed-off-by: Jingjing Wu Applied, thanks Does it mean that Tx with i40evf never worked before?