From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ophir Munk Subject: [PATCH v1] net/mlx4: fix RSS actions with no parameters Date: Wed, 21 Feb 2018 13:38:38 +0000 Message-ID: <1519220318-19328-1-git-send-email-ophirmu@mellanox.com> Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org To: Adrien Mazarguil Return-path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 4A9042C18 for ; Wed, 21 Feb 2018 14:39:15 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When creating an RSS flow with missing actions parameters, for example: flow create 0 ingress pattern / end actions rss / end testpmd aborts with segmentation fault. In the corrupted code mlx4_flow_prepare() accesses RSS action->conf pointer without verifying its validity. In case of missing RSS actions parameters this pointer is NULL and must not be accessed. The fix is to return an error in such cases "missing rss actions". Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4_flow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 2d55bfe..7a127a8 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -735,6 +735,10 @@ mlx4_flow_prepare(struct priv *priv, if (flow->rss) break; rss = action->conf; + if (!rss) { + msg = "missing rss actions"; + goto exit_action_not_supported; + } /* Default RSS configuration if none is provided. */ rss_conf = rss->rss_conf ? -- 2.7.4