From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Date: Wed, 30 Mar 2016 16:06:40 +0200 Message-ID: <1519299.Ljb19TASP1@xps13> References: <1455605170-16137-1-git-send-email-thomas.monjalon@6wind.com> <1455605170-16137-3-git-send-email-thomas.monjalon@6wind.com> <3EB4FA525960D640B5BDFFD6A3D891264797454E@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Singh, Jasvinder" , "Zhang, Roy Fan" , "Hunt, David" To: "Dumitrescu, Cristian" Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 4A9D82BA1 for ; Wed, 30 Mar 2016 16:08:34 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id 191so91322767wmq.0 for ; Wed, 30 Mar 2016 07:08:34 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891264797454E@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-30 13:57, Dumitrescu, Cristian: > I think the correct fix is: > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2) || defined(RTE_MACHINE_CPUFLAG_CRC32)) > > We'll test it and send a patch asap. I had prepared this patch. Please be inspired: examples/ip_pipeline: fix SSE4.2 optimization branch The branch was disabled because of a typo in the SSE4.2 flag. Change also the x86_64 flag to use a DPDK one. Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 without SSE4.2") -#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2) +#if defined(RTE_ARCH_X86_64) && defined(RTE_MACHINE_CPUFLAG_SSE4_2)