From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] metrics: fix missing NULL termination Date: Wed, 19 Jul 2017 19:13:07 +0300 Message-ID: <1520852.R20bLQnZlh@xps> References: <20170718094347.5387-1-remy.horton@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6A0E52030 for ; Wed, 19 Jul 2017 18:13:12 +0200 (CEST) In-Reply-To: <20170718094347.5387-1-remy.horton@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/07/2017 12:43, Remy Horton: > The public API (struct rte_metric_name) includes the NULL terminator > byte in RTE_METRICS_MAX_NAME_LENGTH but the library itself internally > excludes it. This makes it possible for an application to receive an > unterminated name string. Fix be enforcing the NULL termination of all > name strings to the length that the public API expects. > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > Signed-off-by: Remy Horton Applied, thanks