From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v13 1/2] ethdev: Add a new event type to notify a queue state changed event Date: Mon, 21 Mar 2016 09:37:07 +0100 Message-ID: <1523315.o3rXJh0SOG@xps13> References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp> <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com, ann.zhuangyanying@huawei.com To: Tetsuya Mukawa Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 7124E29B6 for ; Mon, 21 Mar 2016 09:38:45 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id l68so112213089wml.1 for ; Mon, 21 Mar 2016 01:38:45 -0700 (PDT) In-Reply-To: <1458539108-15686-2-git-send-email-mukawa@igel.co.jp> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-21 14:45, Tetsuya Mukawa: > This event will be occured when some queues are enabled or disabled. > So far, only vhost PMD supports the event, and it indicates some queues > are enabled or disabled by virtio-net device. Such an event is needed > because virtio-net device may not enable all queues vhost PMD prepare. > > Because only vhost PMD uses the event so far, it isn't an actual hardware > interrupt but a simple software event. [...] > > + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > + /**< queue state changed interrupt */ Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough? What about this comment? /**< queue state event (enabled/disabled) */