From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] app/testpmd: do not enable Rx offloads by
	default
Date: Mon, 29 Jan 2018 12:52:10 +0100
Message-ID: <1526570.x4yMYrLSQg@xps>
References: <1516695081-178919-1-git-send-email-motih@mellanox.com>
 <1517225598-132061-1-git-send-email-motih@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Moti Haimovsky <motih@mellanox.com>, dev@dpdk.org
To: wenzhuo.lu@intel.com, ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 345101B68F
 for <dev@dpdk.org>; Mon, 29 Jan 2018 12:52:57 +0100 (CET)
In-Reply-To: <1517225598-132061-1-git-send-email-motih@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/01/2018 12:33, Moti Haimovsky:
> Removed the hardcoded preconfigured Rx offload configuration from
> testpmd and changed the Rx offload command line parameters from
> disable to enable.
> Testers who wish to use these offloads will now have to explicitly
> write them in the command-line when running testpmd.
> 
> Motivation:
> Some PMDs such at the mlx4 may not implement all the offloads.
> After the offload API rework assuming no offload is enabled by default,
>   commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
>   commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying
> to enable a not supported offload is clearly an error which will cause
> configuration failing.
> 
> Considering that testpmd is an application to test the PMD, it should
> not fail on a configuration which was not explicitly requested.
> The behavior of this test application is then turned to an opt-in
> model.
> 
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>

This is a very good step in the right direction
because testpmd is a tool app.
So testpmd must not enable anything without explicit user request.

The next step will be to check the offload capabilities
before enabling them.
If a requested capability is not available, it should return
either an error, or a warning.

I want to merge this first patch in 18.02-rc2,
because some drivers (lacking some capabilities) cannot be tested
without explicitly disabling the forced offloads.