From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH] nfp: restore the unlink operation Date: Fri, 18 May 2018 14:22:22 +0100 Message-ID: <1526649742.23337.142.camel@debian.org> References: <20180514144658.9671-1-aconole@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Alejandro Lucero , Eelco Chaudron , Yuanhan Liu , dev@dpdk.org To: Aaron Conole , stable@dpdk.org Return-path: In-Reply-To: <20180514144658.9671-1-aconole@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote: > For the stable versions of DPDK, the NFP driver's NSP user space > driver was modified to account for non-root usage.=C2=A0=C2=A0When that > happened, commit 515933ad8385 ("nfp: allow for non-root user") > inadvertently removed the unlink() call. >=20 > Fixes: 515933ad8385 ("nfp: allow for non-root user") > Cc: Alejandro Lucero > Cc: Luca Boccassi > Cc: Eelco Chaudron > Cc: Yuanhan Liu > Signed-off-by: Aaron Conole > --- > =C2=A0drivers/net/nfp/nfp_nfpu.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c > index ae2e07220..c003640c7 100644 > --- a/drivers/net/nfp/nfp_nfpu.c > +++ b/drivers/net/nfp/nfp_nfpu.c > @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc) > =C2=A0 close(desc->lock); > =C2=A0 > =C2=A0 nspu_get_lockfile_path(lockname, sizeof(lockname), desc); > + unlink(lockname); > =C2=A0 return 0; > =C2=A0} Applied and pushed to stable/18.02 Next time, please send patches that are only for stable to stable@dpdk. org and do not include dev@dpdk.org Also use --subject-prefix=3D'PATCH ' so that we can understand for which branches a patch is --=20 Kind regards, Luca Boccassi