From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] fbarray: make all fbarrays hidden files
Date: Mon, 23 Apr 2018 21:56:01 +0200
Message-ID: <1528313.VrkqK0vgdz@xps>
References: <738d08e521a8987ceeb2748db5b765d8b8531e54.1524481846.git.anatoly.burakov@intel.com>
 <20180423124832.GA100540@bricha3-MOBL.ger.corp.intel.com>
 <f1e2dfb7-278c-8310-c198-1a2c17f7dfdc@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0F4A61066
 for <dev@dpdk.org>; Mon, 23 Apr 2018 21:56:03 +0200 (CEST)
In-Reply-To: <f1e2dfb7-278c-8310-c198-1a2c17f7dfdc@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/04/2018 15:47, Burakov, Anatoly:
> On 23-Apr-18 1:48 PM, Bruce Richardson wrote:
> > On Mon, Apr 23, 2018 at 12:14:13PM +0100, Anatoly Burakov wrote:
> >> fbarray stores its data in a shared file, which is not hidden.
> >> This leads to polluting user's HOME directory with visible
> >> files when running DPDK as non-root. Change fbarray to always
> >> create hidden files by default.
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> ---
> >>
> >> Notes:
> >>      Is /tmp always user-accessible? Maybe not use home
> >>      directory at all?
> >>
> > Good change.
> > 
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks


> > A further improvement would to put the files as not-hidden but inside a
> > hidden subdirectory e.g. ".dpdk"
> 
> Good suggestions, I'll work on this.

There are other places where we create file.
Please try to move all in the same place.