From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: [PATCH] net/bnxt: add missing ids in xstats Date: Thu, 7 Jun 2018 07:36:05 +0200 Message-ID: <1528349765-31471-1-git-send-email-david.marchand@6wind.com> Cc: ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, stable@dpdk.org To: dev@dpdk.org Return-path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 94BDA1B1D8 for ; Thu, 7 Jun 2018 07:36:15 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id d2-v6so8540638wrm.10 for ; Wed, 06 Jun 2018 22:36:15 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The xstats api expects that the driver fills both values and ids for each filled entries. Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Signed-off-by: David Marchand --- drivers/net/bnxt/bnxt_stats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index bbd4e78..a5d3c86 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -278,6 +278,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, count = 0; for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { uint64_t *rx_stats = (uint64_t *)bp->hw_rx_port_stats; + xstats[count].id = count; xstats[count].value = rte_le_to_cpu_64( *(uint64_t *)((char *)rx_stats + bnxt_rx_stats_strings[i].offset)); @@ -286,6 +287,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, for (i = 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) { uint64_t *tx_stats = (uint64_t *)bp->hw_tx_port_stats; + xstats[count].id = count; xstats[count].value = rte_le_to_cpu_64( *(uint64_t *)((char *)tx_stats + bnxt_tx_stats_strings[i].offset)); @@ -293,6 +295,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, } /* The Tx drop pkts aka the Anti spoof coounter */ + xstats[count].id = count; xstats[count].value = rte_le_to_cpu_64(tx_drop_pkts); count++; -- 2.7.4