From mboxrd@z Thu Jan 1 00:00:00 1970 From: Beilei Xing Subject: [PATCH] net/i40e: fix fail to set TPID with AQ command Date: Thu, 5 Jul 2018 15:03:08 +0800 Message-ID: <1530774188-2369-1-git-send-email-beilei.xing@intel.com> Cc: dev@dpdk.org, jingjing.wu@intel.com, james.zheng@intel.com, stable@dpdk.org To: qi.z.zhang@intel.com Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" TPID can be set by set_switch_config AdminQ command on new FW release. But find fail to set 0x88A8 on some NICs. According to the datasheet, Switch Tag value should not be identical to either the First Tag or Second Tag values. So set something other than common Ethertype for internal switching. Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register setting") Cc: stable@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index c47b9f5..93b8d6e 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1242,6 +1242,13 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) hw->bus.func = pci_dev->addr.function; hw->adapter_stopped = 0; + /* + * Switch Tag value should not be identical to either the First Tag + * or Second Tag values. So set something other than common Ethertype + * for internal switching. + */ + hw->switch_tag = 0xffff; + /* Check if need to support multi-driver */ i40e_support_multi_driver(dev); -- 2.5.5