From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhao Wei Subject: [PATCH v2] net/i40e: fix FDIR check programming status error Date: Fri, 13 Jul 2018 11:09:00 +0800 Message-ID: <1531451340-36952-1-git-send-email-wei.zhao1@intel.com> References: <1531297520-16545-1-git-send-email-wei.zhao1@intel.com> Cc: qi.z.zhang@intel.com, stable@dpdk.org, Wei Zhao To: dev@dpdk.org Return-path: In-Reply-To: <1531297520-16545-1-git-send-email-wei.zhao1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info to upper function, the fact for this is it is time out for DD write back and it should return -1. Fixes: 05999aab4ca6 ("i40e: add or delete flow director") Signed-off-by: Wei Zhao --- v2: -fix patch error in ret value set. --- drivers/net/i40e/i40e_fdir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index d41601a..a4c8722 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1360,7 +1360,8 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq) I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); else I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1); - } + } else + ret = -1; return ret; } -- 2.7.5