From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: [PATCH] devargs: fix devargs truncation when format string is used Date: Wed, 18 Jul 2018 08:23:30 +0100 Message-ID: <1531898610-19654-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Gaetan Rivet To: Return-path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id D8F06160 for ; Wed, 18 Jul 2018 09:23:37 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Space for string terminating NUL character should be provided to snprintf() to avoid the last symbol truncation. Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function") Reported-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- lib/librte_eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index a22a2002e..5ec688aab 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -285,7 +285,7 @@ rte_devargs_parsef(struct rte_devargs *da, const char *format, ...) } va_start(ap, format); - vsnprintf(dev, len, format, ap); + vsnprintf(dev, len + 1, format, ap); va_end(ap); return rte_devargs_parse(da, dev); -- 2.17.1