From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH v4] net/bonding: per-slave intermediate rx ring Date: Tue, 21 Aug 2018 12:13:11 +0100 Message-ID: <1534849991.5764.102.camel@debian.org> References: <20180816125202.15980-1-bluca@debian.org> <20180816133208.26566-1-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Declan Doherty , Chas Williams , "stable@dpdk.org" To: Matan Azrad , Chas Williams <3chas3@gmail.com> Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2018-08-21 at 10:56 +0000, Matan Azrad wrote: > Hi >=20 > From: Chas Williams > > This will need to be implemented for some of the other RX burst > > methods at > > some point for other modes to see this performance improvement > > (with the > > exception of active-backup). >=20 > Yes, I think it should be done at least to > bond_ethdev_rx_burst_8023ad_fast_queue (should be easy) for now. >=20 > > On Thu, Aug 16, 2018 at 9:32 AM Luca Boccassi > > wrote: > >=20 > > > During bond 802.3ad receive, a burst of packets is fetched from > > > each > > > slave into a local array and appended to per-slave ring buffer. > > > Packets are taken from the head of the ring buffer and returned > > > to the > > > caller.=C2=A0=C2=A0The number of mbufs provided to each slave is suff= icient > > > to > > > meet the requirements of the ixgbe vector receive. >=20 > Luca, >=20 > Can you explain these requirements of ixgbe? I think Chas knows this better than I do. Chas? > Did you check for other vendor PMDs? It may hurt performance there.. Yeah we do support the appliance with more drivers - off the top of my head at the very least e1000, i40e, bnxt, and I'm pretty sure there are users that run with bonded virtio interfaces (yeah I know). No issues were reported as far as I'm aware. --=20 Kind regards, Luca Boccassi