From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 4/4] build: install igb_uio kernel module
 when building with Meson
Date: Fri, 31 Aug 2018 11:19:08 +0100
Message-ID: <1535710748.11823.23.camel@debian.org>
References: <20180831092029.4887-1-bluca@debian.org>
 <20180831092029.4887-4-bluca@debian.org>
 <20180831101520.GA19592@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id B5FE2231E
 for <dev@dpdk.org>; Fri, 31 Aug 2018 12:19:10 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id r1-v6so843938wmh.0
 for <dev@dpdk.org>; Fri, 31 Aug 2018 03:19:10 -0700 (PDT)
In-Reply-To: <20180831101520.GA19592@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2018-08-31 at 11:15 +0100, Bruce Richardson wrote:
> On Fri, Aug 31, 2018 at 10:20:29AM +0100, Luca Boccassi wrote:
> > Install in $kerneldir/../extra/dpdk. Usually $kerneldir should
> > something
> > like: /lib/modules/$kver/build, so this directory will match the
> > default
> > one used by legacy makefiles.
> >=20
> > Fixes: a52f4574f798 ("igb_uio: build with meson")
> >=20
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > =C2=A0kernel/linux/igb_uio/meson.build | 2 ++
> > =C2=A0meson_options.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 2 +-
> > =C2=A02 files changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/kernel/linux/igb_uio/meson.build
> > b/kernel/linux/igb_uio/meson.build
> > index 71ed2e7a85..f5a9d5ccf3 100644
> > --- a/kernel/linux/igb_uio/meson.build
> > +++ b/kernel/linux/igb_uio/meson.build
> > @@ -15,4 +15,6 @@ custom_target('igb_uio',
> > =C2=A0			'/../../../lib/librte_eal/common/include',
> > =C2=A0		'modules'],
> > =C2=A0	depends: mkfile,
> > +	install: true,
> > +	install_dir: kernel_dir + '/../extra/dpdk',
> > =C2=A0	build_by_default: get_option('enable_kmods'))
> > diff --git a/meson_options.txt b/meson_options.txt
> > index c843278587..f452986da3 100644
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > @@ -7,7 +7,7 @@ option('examples', type: 'string', value: '',
> > =C2=A0option('include_subdir_arch', type: 'string', value: '',
> > =C2=A0	description: 'subdirectory where to install arch-dependent=20
> > headers')
> > =C2=A0option('kernel_dir', type: 'string', value: '',
> > -	description: 'path to the kernel for building kernel
> > modules')
> > +	description: 'path to the kernel for building kernel
> > modules, they will be installed in
> > $prefix/$kernel_dir/../extra/dpdk')
>=20
> Will $prefix be used in the install path? I thought it would be
> $DEST_DIR?

Yeah it was meant as a pseudo-variable :-)

--=20
Kind regards,
Luca Boccassi