From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 2/4] build: use -Wno-error=format-security
 for Meson ifpga_rawdev build
Date: Fri, 31 Aug 2018 11:35:27 +0100
Message-ID: <1535711727.11823.24.camel@debian.org>
References: <20180831092029.4887-1-bluca@debian.org>
 <20180831092029.4887-2-bluca@debian.org>
 <20180831101733.GB19592@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 54FA52BF7
 for <dev@dpdk.org>; Fri, 31 Aug 2018 12:35:29 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id t25-v6so4848047wmi.3
 for <dev@dpdk.org>; Fri, 31 Aug 2018 03:35:29 -0700 (PDT)
In-Reply-To: <20180831101733.GB19592@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2018-08-31 at 11:17 +0100, Bruce Richardson wrote:
> On Fri, Aug 31, 2018 at 10:20:27AM +0100, Luca Boccassi wrote:
> > This PMD is built with -Wno-format, which means GCC errors out if
> > -Wformat-security is used.
> >=20
> > Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share
> > code")
> >=20
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > =C2=A0drivers/raw/ifpga_rawdev/base/meson.build | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/raw/ifpga_rawdev/base/meson.build
> > b/drivers/raw/ifpga_rawdev/base/meson.build
> > index cb6553521d..aadfc19084 100644
> > --- a/drivers/raw/ifpga_rawdev/base/meson.build
> > +++ b/drivers/raw/ifpga_rawdev/base/meson.build
> > @@ -19,7 +19,7 @@ sources =3D [
> > =C2=A0
> > =C2=A0error_cflags =3D ['-Wno-sign-compare', '-Wno-unused-value',
> > =C2=A0		'-Wno-format', '-Wno-unused-but-set-variable',
> > -		'-Wno-strict-aliasing'
> > +		'-Wno-strict-aliasing', '-Wno-error=3Dformat-
> > security'
>=20
> For readability, should format-security be placed right beside the
> Wno-format, since both go together? Makes the diff a little bigger,
> but the
> result would be better, I feel.
>=20
> /Bruce

Sure, will change that.

--=20
Kind regards,
Luca Boccassi