From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] build: get version number from header file
Date: Fri, 31 Aug 2018 15:10:42 +0100
Message-ID: <1535724642.11823.26.camel@debian.org>
References: <20180831135132.14730-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>, bruce.richardson@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 9808F7D26
 for <dev@dpdk.org>; Fri, 31 Aug 2018 16:10:50 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id s12-v6so5410544wmc.0
 for <dev@dpdk.org>; Fri, 31 Aug 2018 07:10:50 -0700 (PDT)
In-Reply-To: <20180831135132.14730-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2018-08-31 at 15:51 +0200, Thomas Monjalon wrote:
> The header file rte_version.h should be the unique place
> to define the version number.
> The makefile command "showversion" makes it accessible,
> and it is used to set the meson project version with an external
> command.
>=20
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>=20
> I don't know how to check easily the meson version number.
> Please help in testing, thanks.
>=20
> ---
> =C2=A0meson.build | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/meson.build b/meson.build
> index 84af32ece..b9d1030e7 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2,7 +2,7 @@
> =C2=A0# Copyright(c) 2017 Intel Corporation
> =C2=A0
> =C2=A0project('DPDK', 'C',
> -	version: '18.11-rc0',
> +	version: run_command('make',
> 'showversion').stdout().strip(),
> =C2=A0	license: 'BSD',
> =C2=A0	default_options: ['buildtype=3Drelease',
> 'default_library=3Dstatic'],
> =C2=A0	meson_version: '>=3D 0.41'

Isn't the ultimate end goal to remove the makefiles? If so, shouldn't
meson be independent?

--=20
Kind regards,
Luca Boccassi