From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] librte_cmdline: FreeBSD Fix oveflow when size of command result structure is greater than BUFSIZ Date: Fri, 05 Dec 2014 16:58:16 +0100 Message-ID: <1536173.TcPGvUY4rp@xps13> References: <5481BE26.9080903@6wind.com> <1417789147-5636-1-git-send-email-olivier.matz@6wind.com> <20141205155100.GA9040@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Alan Carew Return-path: In-Reply-To: <20141205155100.GA9040@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > When using test-pmd with flow director in FreeBSD, the application will > > segfault/Bus error while parsing the command-line. This is due to how > > each commands result structure is represented during parsing, where the offsets > > for each tokens value is stored in a character array(char result_buf[BUFSIZ]) > > in cmdline_parse()(./lib/librte_cmdline/cmdline_parse.c). > > > > The overflow occurs where BUFSIZ is less than the size of a commands result > > structure, in this case "struct cmd_pkt_filter_result" > > (app/test-pmd/cmdline.c) is 1088 bytes and BUFSIZ on FreeBSD is 1024 bytes as > > opposed to 8192 bytes on Linux. > > > > The problem can be reproduced by running test-pmd on FreeBSD: > > ./testpmd -c 0x3 -n 4 -- -i --portmask=0x3 --pkt-filter-mode=perfect > > And adding a filter: > > add_perfect_filter 0 udp src 192.168.0.0 1024 dst 192.168.0.0 1024 flexbytes > > 0x800 vlan 0 queue 0 soft 0x17 > > > > This patch removes the OS dependency on BUFSIZ and defines and uses a > > library #define CMDLINE_PARSE_RESULT_BUFSIZE 8192 > > > > Added boundary checking to ensure this buffer size cannot overflow, with > > an error message being produced. > > > > Suggested-by: Olivier MATZ > > http://git.droids-corp.org/?p=libcmdline.git;a=commitdiff;h=b1d5b169352e57df3fc14c51ffad4b83f3e5613f > > > > Signed-off-by: Alan Carew > > Signed-off-by: Olivier MATZ > > Tested on FreeBSD 10 and this patch fixes the issue described. > > Tested-by: Bruce Richardson Applied Thank you all -- Thomas