From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] port: fix source and sink port
Date: Fri, 01 Apr 2016 12:28:07 +0200
Message-ID: <1536333.27nVV74cJ2@xps13>
References: <1459504512-6114-1-git-send-email-roy.fan.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Fan Zhang <roy.fan.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 958ED2716
 for <dev@dpdk.org>; Fri,  1 Apr 2016 12:30:03 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id 127so15050988wmu.1
 for <dev@dpdk.org>; Fri, 01 Apr 2016 03:30:03 -0700 (PDT)
In-Reply-To: <1459504512-6114-1-git-send-email-roy.fan.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The title don't talk about pcap. Is it touching only pcap?

2016-04-01 10:55, Fan Zhang:
> Fixes: eb5f411 ("port: add pcap file dump")
> 
> This patch fixes pcap supporting logic. The fix includes:

What was the issue?

> * Adding logic to detect illegal parameter.
> * Clearer error message display.
> * Remove unnecessary RTE_NEXT_ABI macro warping.
> * Code clean-up

Maybe these changes can be split?