From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH v2 1/9] build: add Meson file for TAP PMD Date: Thu, 13 Sep 2018 14:28:28 +0100 Message-ID: <1536845308.10952.52.camel@debian.org> References: <20180910200415.8340-1-bluca@debian.org> <20180911160903.27226-1-bluca@debian.org> <20180913131109.GA14728@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 015477CDE for ; Thu, 13 Sep 2018 15:28:31 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id j25-v6so1705452wmc.1 for ; Thu, 13 Sep 2018 06:28:31 -0700 (PDT) In-Reply-To: <20180913131109.GA14728@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2018-09-13 at 14:11 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 05:08:55PM +0100, Luca Boccassi wrote: > > Use same autoconf generation mechanism as the MLX4/5 PMDs > >=20 > > Signed-off-by: Luca Boccassi > > --- > > =C2=A0drivers/net/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2= =A01 + > > =C2=A0drivers/net/tap/meson.build | 41 > > +++++++++++++++++++++++++++++++++++++ > > =C2=A02 files changed, 42 insertions(+) > > =C2=A0create mode 100644 drivers/net/tap/meson.build > >=20 > > diff --git a/drivers/net/meson.build b/drivers/net/meson.build > > index c7a2d0e7db..b7b4870eb8 100644 > > --- a/drivers/net/meson.build > > +++ b/drivers/net/meson.build > > @@ -27,6 +27,7 @@ drivers =3D ['af_packet', > > =C2=A0 'sfc', > > =C2=A0 'softnic', > > =C2=A0 'szedata2', > > + 'tap', > > =C2=A0 'thunderx', > > =C2=A0 'vhost', > > =C2=A0 'virtio'] > > diff --git a/drivers/net/tap/meson.build > > b/drivers/net/tap/meson.build > > new file mode 100644 > > index 0000000000..ef3c6e1fee > > --- /dev/null > > +++ b/drivers/net/tap/meson.build > > @@ -0,0 +1,41 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright 2018 Luca Boccassi > > + > > +sources =3D files( > > + 'rte_eth_tap.c', > > + 'tap_bpf_api.c', > > + 'tap_flow.c', > > + 'tap_intr.c', > > + 'tap_netlink.c', > > + 'tap_tcmsgs.c', > > +) > > + > > +deps =3D ['bus_vdev', 'gso', 'hash'] > > + > > +cflags +=3D '-DTAP_MAX_QUEUES=3D16' > > + > > +# To maintain the compatibility with the make build system > > +# tap_autoconf.h file is still generated. > > +# input array for meson symbol search: > > +# [ "MACRO to define if found", "header for the search", > > +#=C2=A0=C2=A0=C2=A0"enum/define", "symbol to search" ] > > +# > > +args =3D [ > > + [ 'HAVE_TC_FLOWER', 'linux/pkt_cls.h', > > + =C2=A0=C2=A0'enum', 'TCA_FLOWER_UNSPEC' ], > > + [ 'HAVE_TC_VLAN_ID', 'linux/pkt_cls.h', > > + =C2=A0=C2=A0'enum', 'TCA_FLOWER_KEY_VLAN_PRIO' ], > > + [ 'HAVE_TC_BPF', 'linux/pkt_cls.h', > > + =C2=A0=C2=A0'enum', 'TCA_BPF_UNSPEC' ], > > + [ 'HAVE_TC_BPF_FD', 'linux/pkt_cls.h', > > + =C2=A0=C2=A0'enum', 'TCA_BPF_FD' ], > > + [ 'HAVE_TC_ACT_BPF', 'linux/tc_act/tc_bpf.h', > > + =C2=A0=C2=A0'enum', 'TCA_ACT_BPF_UNSPEC' ], > > + [ 'HAVE_TC_ACT_BPF_FD', 'linux/tc_act/tc_bpf.h', > > + =C2=A0=C2=A0'enum', 'TCA_ACT_BPF_FD' ], > > +] > > +config =3D configuration_data() > > +foreach arg:args > > + config.set(arg[0], cc.has_header_symbol(arg[1], arg[3])) > > +endforeach > > +configure_file(output : 'tap_autoconf.h', configuration : config) > > --=C2=A0 >=20 > Minor nit, arg 2 is unused, and this could be dropped, as is done in > the > latest version of the mlnx meson build files. >=20 > /Bruce Ok, will fix in v3 --=20 Kind regards, Luca Boccassi