From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug Date: Tue, 18 Sep 2018 14:14:54 +0100 Message-ID: <1537276494.10481.7.camel@debian.org> References: <20180816135032.28283-1-bluca@debian.org> <20180816135032.28283-3-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Cc: "maxime.coquelin@redhat.com" , "tiwei.bie@intel.com" , Yong Wang , "3chas3@gmail.com" <3chas3@gmail.com>, "bruce.richardson@intel.com" , "jianfeng.tan@intel.com" , "anatoly.burakov@intel.com" , "stable@dpdk.org" , Brian Russell To: Louis Luo , "dev@dpdk.org" Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SGksCgpUaGUgYXBwbGljYXRpb24gbXVzdCBhbHJlYWR5IHN0b3AgYW5kIGNsb3NlIGJlZm9yZSBk ZXRhY2hpbmcgKHdoaWNoCndpbGwgY2FsbCB1bmluaXQpLiBRdW90aW5nIGZyb20gdGhlIGRvY3Vt ZW50YXRpb246CgoiKsKgwqBCZWZvcmUgZGV0YWNoaW5nLCB0aGV5IG11c3QgYmUgc3RvcHBlZCBh bmQgY2xvc2VkLgoKwqAgwqDCoERQREsgYXBwbGljYXRpb25zIG11c3QgY2FsbCAicnRlX2V0aF9k ZXZfc3RvcCgpIiBhbmQKwqDCoCDCoCJydGVfZXRoX2Rldl9jbG9zZSgpIiBBUElzIGJlZm9yZSBk ZXRhY2hpbmcgcG9ydHMuIFRoZXNlIGZ1bmN0aW9ucyB3aWxsCsKgwqAgwqBzdGFydCBmaW5hbGl6 YXRpb24gc2VxdWVuY2Ugb2YgdGhlIFBNRHMuIgoKaHR0cDovL2RvYy5kcGRrLm9yZy9ndWlkZXMv cHJvZ19ndWlkZS9wb3J0X2hvdHBsdWdfZnJhbWV3b3JrLmh0bWwKCk9uIE1vbiwgMjAxOC0wOS0x NyBhdCAxOTowNiArMDAwMCwgTG91aXMgTHVvIHdyb3RlOgo+IEhpIEx1Y2EsCj4gCj4gV2hlbiBl dGhfdm14bmV0M19kZXZfdW5pbml0KCkgaXMgY2FsbGVkLCBpcyBpdCBndWFyYW50ZWVkIHRoYXQK PiB2bXhuZXQzX2Rldl9jbG9zZS8gdm14bmV0M19kZXZfc3RvcCBtdXN0IGhhdmUgYmVlbiBjYWxs ZWQ/IEknbSBub3QKPiBmYW1pbGlhciB3aXRoIHRoZSBob3QtcGx1ZyBwcm9jZWR1cmUsIHNvIGp1 c3Qgd29uZGVyIGlmIHRoZXJlIGlzIGFueQo+IGNoYW5jZSB0aGF0IGV0aF92bXhuZXQzX2Rldl91 bmluaXQoKSBpcyBjYWxsZWQgd2l0aG91dCBjYWxsaW5nCj4gdm14bmV0M19kZXZfY2xvc2UvIHZt eG5ldDNfZGV2X3N0b3AuCj4gCj4gVGhhbmtzLAo+IExvdWlzCj4gCj4g77u/T24gOC8xNi8xOCwg Njo1MSBBTSwgImRldiBvbiBiZWhhbGYgb2YgTHVjYSBCb2NjYXNzaSIgPGRldi1ib3VuY2VzQGQK PiBwZGsub3JnIG9uIGJlaGFsZiBvZiBibHVjYUBkZWJpYW4ub3JnPiB3cm90ZToKPiAKPiDCoMKg wqDCoFRoZSB2bXhuZXQzIGRyaXZlciBjYW4ndCBjYWxsIGJhY2sgaW50byBkZXZfY2xvc2UoKSwg YW5kIHBvc3NpYmx5Cj4gwqDCoMKgwqBkZXZfc3RvcCgpLCBpbiBkZXZfdW5pbml0KCkuwqDCoFdo ZW4gZGV2X3VuaW5pdCgpIGlzIGNhbGxlZCwKPiBhbnl0aGluZwo+IMKgwqDCoMKgdGhhdCB0aG9z ZSByb3V0aW5lcyB3b3VsZCB3YW50IHRvIGNsZWFuIHVwIGhhcyBhbHJlYWR5IGJlZW4KPiByZWxl YXNlZC4KPiDCoMKgwqDCoEZ1cnRoZXIsIGZvciBjb21wbGV0ZSBjbGVhbnVwLCBpdCBpcyBuZWNl c3NhcnkgdG8gcmVsZWFzZSBhbnkgb2YKPiB0aGUKPiDCoMKgwqDCoHF1ZXVlIHJlc291cmNlcyBk dXJpbmcgZGV2X2Nsb3NlKCkuCj4gwqDCoMKgwqBUaGlzIGFsbG93cyBhIHZteG5ldDMgZGV2aWNl IHRvIGJlIGhvdC11bnBsdWdnZWQgd2l0aG91dCBsZWFraW5nCj4gwqDCoMKgwqBxdWV1ZXMuCj4g wqDCoMKgwqAKPiDCoMKgwqDCoEZpeGVzOiBkZmFmZjM3ZmM0NmQgKCJ2bXhuZXQzOiBpbXBvcnQg bmV3IHZteG5ldDMgcG9sbCBtb2RlCj4gZHJpdmVyIGltcGxlbWVudGF0aW9uIikKPiDCoMKgwqDC oENjOiBzdGFibGVAZHBkay5vcmcKPiDCoMKgwqDCoAo+IMKgwqDCoMKgU2lnbmVkLW9mZi1ieTog QnJpYW4gUnVzc2VsbCA8YnJ1c3NlbGxAYnJvY2FkZS5jb20+Cj4gwqDCoMKgwqBTaWduZWQtb2Zm LWJ5OiBMdWNhIEJvY2Nhc3NpIDxibHVjYUBkZWJpYW4ub3JnPgo+IMKgwqDCoMKgLS0tCj4gwqDC oMKgwqDCoGRyaXZlcnMvbmV0L3ZteG5ldDMvdm14bmV0M19ldGhkZXYuYyB8IDM2ICsrKysrKysr KysrKysrKysrKysrCj4gLS0tLS0tLS0KPiDCoMKgwqDCoMKgMSBmaWxlIGNoYW5nZWQsIDI2IGlu c2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+IMKgwqDCoMKgCj4gwqDCoMKgwqBkaWZmIC0t Z2l0IGEvZHJpdmVycy9uZXQvdm14bmV0My92bXhuZXQzX2V0aGRldi5jCj4gYi9kcml2ZXJzL25l dC92bXhuZXQzL3ZteG5ldDNfZXRoZGV2LmMKPiDCoMKgwqDCoGluZGV4IDI2MTNjZDEzNTguLmI1 ZDRiZTVlMjQgMTAwNjQ0Cj4gwqDCoMKgwqAtLS0gYS9kcml2ZXJzL25ldC92bXhuZXQzL3ZteG5l dDNfZXRoZGV2LmMKPiDCoMKgwqDCoCsrKyBiL2RyaXZlcnMvbmV0L3ZteG5ldDMvdm14bmV0M19l dGhkZXYuYwo+IMKgwqDCoMKgQEAgLTM0OCwxNiArMzQ4LDExIEBAIGV0aF92bXhuZXQzX2Rldl9p bml0KHN0cnVjdCBydGVfZXRoX2Rldgo+ICpldGhfZGV2KQo+IMKgwqDCoMKgwqBzdGF0aWMgaW50 Cj4gwqDCoMKgwqDCoGV0aF92bXhuZXQzX2Rldl91bmluaXQoc3RydWN0IHJ0ZV9ldGhfZGV2ICpl dGhfZGV2KQo+IMKgwqDCoMKgwqB7Cj4gwqDCoMKgwqAtCXN0cnVjdCB2bXhuZXQzX2h3ICpodyA9 IGV0aF9kZXYtPmRhdGEtPmRldl9wcml2YXRlOwo+IMKgwqDCoMKgLQo+IMKgwqDCoMKgwqAJUE1E X0lOSVRfRlVOQ19UUkFDRSgpOwo+IMKgwqDCoMKgwqAKPiDCoMKgwqDCoMKgCWlmIChydGVfZWFs X3Byb2Nlc3NfdHlwZSgpICE9IFJURV9QUk9DX1BSSU1BUlkpCj4gwqDCoMKgwqDCoAkJcmV0dXJu IDA7Cj4gwqDCoMKgwqDCoAo+IMKgwqDCoMKgLQlpZiAoaHctPmFkYXB0ZXJfc3RvcHBlZCA9PSAw KQo+IMKgwqDCoMKgLQkJdm14bmV0M19kZXZfY2xvc2UoZXRoX2Rldik7Cj4gwqDCoMKgwqAtCj4g wqDCoMKgwqDCoAlldGhfZGV2LT5kZXZfb3BzID0gTlVMTDsKPiDCoMKgwqDCoMKgCWV0aF9kZXYt PnJ4X3BrdF9idXJzdCA9IE5VTEw7Cj4gwqDCoMKgwqDCoAlldGhfZGV2LT50eF9wa3RfYnVyc3Qg PSBOVUxMOwo+IMKgwqDCoMKgQEAgLTgwMyw3ICs3OTgsNyBAQCB2bXhuZXQzX2Rldl9zdG9wKHN0 cnVjdCBydGVfZXRoX2RldiAqZGV2KQo+IMKgwqDCoMKgwqAJUE1EX0lOSVRfRlVOQ19UUkFDRSgp Owo+IMKgwqDCoMKgwqAKPiDCoMKgwqDCoMKgCWlmIChody0+YWRhcHRlcl9zdG9wcGVkID09IDEp IHsKPiDCoMKgwqDCoC0JCVBNRF9JTklUX0xPRyhERUJVRywgIkRldmljZSBhbHJlYWR5IGNsb3Nl ZC4iKTsKPiDCoMKgwqDCoCsJCVBNRF9JTklUX0xPRyhERUJVRywgIkRldmljZSBhbHJlYWR5IHN0 b3BwZWQuIik7Cj4gwqDCoMKgwqDCoAkJcmV0dXJuOwo+IMKgwqDCoMKgwqAJfQo+IMKgwqDCoMKg wqAKPiDCoMKgwqDCoEBAIC04MjcsNyArODIyLDYgQEAgdm14bmV0M19kZXZfc3RvcChzdHJ1Y3Qg cnRlX2V0aF9kZXYgKmRldikKPiDCoMKgwqDCoMKgCS8qIHJlc2V0IHRoZSBkZXZpY2UgKi8KPiDC oMKgwqDCoMKgCVZNWE5FVDNfV1JJVEVfQkFSMV9SRUcoaHcsIFZNWE5FVDNfUkVHX0NNRCwKPiBW TVhORVQzX0NNRF9SRVNFVF9ERVYpOwo+IMKgwqDCoMKgwqAJUE1EX0lOSVRfTE9HKERFQlVHLCAi RGV2aWNlIHJlc2V0LiIpOwo+IMKgwqDCoMKgLQlody0+YWRhcHRlcl9zdG9wcGVkID0gMDsKPiDC oMKgwqDCoMKgCj4gwqDCoMKgwqDCoAl2bXhuZXQzX2Rldl9jbGVhcl9xdWV1ZXMoZGV2KTsKPiDC oMKgwqDCoMKgCj4gwqDCoMKgwqBAQCAtODM3LDYgKzgzMSwzMCBAQCB2bXhuZXQzX2Rldl9zdG9w KHN0cnVjdCBydGVfZXRoX2RldiAqZGV2KQo+IMKgwqDCoMKgwqAJbGluay5saW5rX3NwZWVkID0g RVRIX1NQRUVEX05VTV8xMEc7Cj4gwqDCoMKgwqDCoAlsaW5rLmxpbmtfYXV0b25lZyA9IEVUSF9M SU5LX0ZJWEVEOwo+IMKgwqDCoMKgwqAJcnRlX2V0aF9saW5rc3RhdHVzX3NldChkZXYsICZsaW5r KTsKPiDCoMKgwqDCoCsKPiDCoMKgwqDCoCsJaHctPmFkYXB0ZXJfc3RvcHBlZCA9IDE7Cj4gwqDC oMKgwqArfQo+IMKgwqDCoMKgKwo+IMKgwqDCoMKgK3N0YXRpYyB2b2lkCj4gwqDCoMKgwqArdm14 bmV0M19mcmVlX3F1ZXVlcyhzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldikKPiDCoMKgwqDCoCt7Cj4g wqDCoMKgwqArCWludCBpOwo+IMKgwqDCoMKgKwo+IMKgwqDCoMKgKwlQTURfSU5JVF9GVU5DX1RS QUNFKCk7Cj4gwqDCoMKgwqArCj4gwqDCoMKgwqArCWZvciAoaSA9IDA7IGkgPCBkZXYtPmRhdGEt Pm5iX3J4X3F1ZXVlczsgaSsrKSB7Cj4gwqDCoMKgwqArCQl2b2lkICpyeHEgPSBkZXYtPmRhdGEt PnJ4X3F1ZXVlc1tpXTsKPiDCoMKgwqDCoCsKPiDCoMKgwqDCoCsJCXZteG5ldDNfZGV2X3J4X3F1 ZXVlX3JlbGVhc2UocnhxKTsKPiDCoMKgwqDCoCsJfQo+IMKgwqDCoMKgKwlkZXYtPmRhdGEtPm5i X3J4X3F1ZXVlcyA9IDA7Cj4gwqDCoMKgwqArCj4gwqDCoMKgwqArCWZvciAoaSA9IDA7IGkgPCBk ZXYtPmRhdGEtPm5iX3R4X3F1ZXVlczsgaSsrKSB7Cj4gwqDCoMKgwqArCQl2b2lkICp0eHEgPSBk ZXYtPmRhdGEtPnR4X3F1ZXVlc1tpXTsKPiDCoMKgwqDCoCsKPiDCoMKgwqDCoCsJCXZteG5ldDNf ZGV2X3R4X3F1ZXVlX3JlbGVhc2UodHhxKTsKPiDCoMKgwqDCoCsJfQo+IMKgwqDCoMKgKwlkZXYt PmRhdGEtPm5iX3R4X3F1ZXVlcyA9IDA7Cj4gwqDCoMKgwqDCoH0KPiDCoMKgwqDCoMKgCj4gwqDC oMKgwqDCoC8qCj4gwqDCoMKgwqBAQCAtODQ1LDEyICs4NjMsMTAgQEAgdm14bmV0M19kZXZfc3Rv cChzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldikKPiDCoMKgwqDCoMKgc3RhdGljIHZvaWQKPiDCoMKg wqDCoMKgdm14bmV0M19kZXZfY2xvc2Uoc3RydWN0IHJ0ZV9ldGhfZGV2ICpkZXYpCj4gwqDCoMKg wqDCoHsKPiDCoMKgwqDCoC0Jc3RydWN0IHZteG5ldDNfaHcgKmh3ID0gZGV2LT5kYXRhLT5kZXZf cHJpdmF0ZTsKPiDCoMKgwqDCoC0KPiDCoMKgwqDCoMKgCVBNRF9JTklUX0ZVTkNfVFJBQ0UoKTsK PiDCoMKgwqDCoMKgCj4gwqDCoMKgwqDCoAl2bXhuZXQzX2Rldl9zdG9wKGRldik7Cj4gwqDCoMKg wqAtCWh3LT5hZGFwdGVyX3N0b3BwZWQgPSAxOwo+IMKgwqDCoMKgKwl2bXhuZXQzX2ZyZWVfcXVl dWVzKGRldik7Cj4gwqDCoMKgwqDCoH0KPiDCoMKgwqDCoMKgCj4gwqDCoMKgwqDCoHN0YXRpYyB2 b2lkCj4gwqDCoMKgwqAtLcKgCj4gwqDCoMKgwqAyLjE4LjAKPiDCoMKgwqDCoAo+IMKgwqDCoMKg Cj4gCgotLSAKS2luZCByZWdhcmRzLApMdWNhIEJvY2Nhc3Np