From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [dpdk-stable] [PATCH] net/bonding: ensure fairness among slaves Date: Wed, 19 Sep 2018 17:06:59 +0100 Message-ID: <1537373219.10481.26.camel@debian.org> References: <20180919154825.5183-1-3chas3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: declan.doherty@intel.com, matan@mellanox.com, ehkinzie@gmail.com, Chas Williams , stable@dpdk.org To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Return-path: In-Reply-To: <20180919154825.5183-1-3chas3@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2018-09-19 at 11:48 -0400, Chas Williams wrote: > From: Chas Williams >=20 > Some PMDs, especially ones with vector receives, require a minimum > number > of receive buffers in order to receive any packets.=C2=A0=C2=A0If the fir= st > slave > read leaves less than this number available, a read from the next > slave > may return 0 implying that the slave doesn't have any packets which > results in skipping over that slave as the next active slave. >=20 > To fix this, implement round robin for the slaves during receive that > is only advanced to the next slave at the end of each receive burst. > This should also provide some additional fairness in processing in > bond_ethdev_rx_burst as well. >=20 > Fixes: 2efb58cbab6e ("bond: new link bonding library") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chas Williams > --- > =C2=A0drivers/net/bonding/rte_eth_bond_pmd.c | 50 ++++++++++++++++++++++ > ------------ > =C2=A01 file changed, 32 insertions(+), 18 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi