From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] acl: fix invalid results for rule with zero
 priority
Date: Tue, 25 Sep 2018 13:22:47 +0100
Message-ID: <1537878167.10481.46.camel@debian.org>
References: <1535129226-25510-1-git-send-email-konstantin.ananyev@intel.com>
 <1912621.YvyjYky8PI@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id E13B81B119
 for <dev@dpdk.org>; Tue, 25 Sep 2018 14:22:49 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id j15-v6so19055948wrt.8
 for <dev@dpdk.org>; Tue, 25 Sep 2018 05:22:49 -0700 (PDT)
In-Reply-To: <1912621.YvyjYky8PI@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote:
> 24/08/2018 18:47, Konstantin Ananyev:
> > If user specifies priority=3D0 for some of ACL rules
> > that can cause rte_acl_classify to return wrong results.
> > The reason is that priority zero is used internally for no-match
> > nodes.
> > See more details at: https://bugs.dpdk.org/show_bug.cgi?id=3D79.
> > The simplest way to overcome the issue is just not allow zero
> > to be a valid priority for the rule.
> >=20
> > Fixes: dc276b5780c2 ("acl: new library")
> >=20
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>=20
> Cc: stable@dpdk.org
>=20
> Applied with below title, thanks
> 	acl: forbid rule with priority zero

Hi,

This patch is marked for stable, but it changes an enum in a public
header so it looks like an ABI breakage? Have I got it wrong?

--=20
Kind regards,
Luca Boccassi