From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH] build: set RTE_ARCH_64 based on pointer size Date: Wed, 26 Sep 2018 11:18:11 +0100 Message-ID: <1537957091.8363.1.camel@debian.org> References: <20180926091536.61370-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable To: Bruce Richardson , dev@dpdk.org Return-path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 918012BF4 for ; Wed, 26 Sep 2018 12:18:13 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id l10-v6so3249372wrp.3 for ; Wed, 26 Sep 2018 03:18:13 -0700 (PDT) In-Reply-To: <20180926091536.61370-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2018-09-26 at 10:15 +0100, Bruce Richardson wrote: > Rather than relying on the target machine architecture, use the > size of a pointer from the compiler to determine if we are 64-bits > or not. This allows correct behaviour when you pass -m32 as a compile > option. It also allows us to use this value repeatedly throughout the > repo rather than continually testing for the sizeof(void*). >=20 > Signed-off-by: Bruce Richardson > --- > =C2=A0config/arm/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 3 +-- > =C2=A0config/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| 5 ++++- > =C2=A0config/ppc_64/meson.build=C2=A0=C2=A0=C2=A0| 4 +++- > =C2=A0config/x86/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 3 +-- > =C2=A0drivers/net/sfc/meson.build | 2 +- > =C2=A0lib/librte_bpf/meson.build=C2=A0=C2=A0| 2 +- > =C2=A0lib/librte_kni/meson.build=C2=A0=C2=A0| 2 +- > =C2=A07 files changed, 12 insertions(+), 9 deletions(-) Tested-by: Luca Boccassi Build-tested on ppc64 and arm64 native Debian sid hosts. --=20 Kind regards, Luca Boccassi